D28744: Rewrite of the global shortcuts kcm

[Nathaniel Graham]

ngraham added a comment.


  Clicking the Apply button makes System Settings crash for me: P591 System Setting scrash log <https://phabricator.kde.org/P591>

INLINE COMMENTS

> main.qml:118
> +                                icon.width: Kirigami.Units.iconSizes.small
> +                                onClicked: kcm.removeComponent(index)
> +                                QQC2.ToolTip {

When I click on it, the KCM enters this state:

F8249469: Screenshot_20200420_094821.png <https://phabricator.kde.org/F8249469>

> main.qml:120
> +                                QQC2.ToolTip {
> +                                    text: i18n("Remove the selected component")
> +                                }

How about "Remove all shortcuts for [model.name]"

> main.qml:167
> +                Component.onCompleted: background.visible = true
> +                QQC2.Label {
> +                    visible: components.currentIndex == -1

Make it a level 3 `Heading`

> main.qml:173
> +                }
> +                ListView {
> +                    clip:true

For some reason this list view doesn't get any sctollbars when it's scrollable. Also it implements kinetic scrolling while the other list view doesn't

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200420/df252076/attachment-0001.html>