D28649: [Notifications] Port to upstream QConcatenateTablesProxyModel

[David Faure]

dfaure added a comment.


  OK I see why this is happening.
  
  KConcatenateProxyModel's columnCount is the number of columns of the first source model. Which leads to strange things if other models have less columns.
  QConcatenateProxyModel takes the smallest number of columns of all source models, to solve that.
  But here the jobs model is empty. And empty model shouldn't be taken into account when calculating the number of columns.
  I'll fix that in QConcatenateProxyModel, but that means you can't use it for another 2 years or so... oh well ;)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28649

To: broulik, #plasma
Cc: davidre, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200419/a6cc9768/attachment.html>