D28908: Use the same icon mode calculation for comboboxes as for buttons

[Noah Davis]

ndavis added a comment.


  In D28908#651314 <https://phabricator.kde.org/D28908#651314>, @davidre wrote:
  
  > In D28908#651078 <https://phabricator.kde.org/D28908#651078>, @ndavis wrote:
  >
  > > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior.
  > >
  > > This patch causes another problem with all monochrome icons on the Breeze colorscheme though:
  > >  F8245273: Screenshot_20200418_104206.png <https://phabricator.kde.org/F8245273>
  >
  >
  > Isn't one of them a toolbuttons with menu, not a combobox? 
  >  I don't think this patches causes that issue. Do you have
  >  https://phabricator.kde.org/R31:66d0b0b4e3e1adc389dbd4ce1976d81860d1880d ?
  
  
  You're right, it looks like this patch doesn't cause the problem. I thought it did because the problem doesn't appear until I change color schemes and I normally change color schemes when testing Breeze patches.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28908

To: davidre, broulik, #breeze
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200418/6affa147/attachment-0001.html>