D28939: Don't offer sending non-http(s) links and sources via KDE Connect

Kai Uwe Broulik noreply at phabricator.kde.org
Sat Apr 18 12:10:29 BST 2020


broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `chrome://` and `about:` pages are typically local and browser-specific, and `blob:` pages cannot be shared altogether.
  
  Only `targetUrlPatterns` but not `documentUrlPatterns` is set so you can still send links from your "New Tab" or history page, evne though that'll mean you could try sharing the page itself which will fail.

TEST PLAN
  Should we include "ftp"?
  
  - No longer get a defunct "Open on $phone" entry for dynamic video streams behind a `blob:` URL
  - No longer get a defunct "Open on $device" entry for many links in browser settings. Ones that only do JS and have an empty target still get it, unfortunately.
  - Can still share links on my "New Tab" and browser history pages

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28939

AFFECTED FILES
  extension/extension-kdeconnect.js

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200418/64db9cd6/attachment.html>


More information about the Plasma-devel mailing list