D28916: fix(kded): center action OSD on wayland

Roman Gilg noreply at phabricator.kde.org
Fri Apr 17 15:03:41 BST 2020


romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Also happy @davidedmundson ?

INLINE COMMENTS

> osd.cpp:33
> +#include <QCursor>
> +#include <QScreen>
>  

Correct lexicographical order on push.

> osd.cpp:143
>      if (auto *rootObject = m_osdActionSelector->rootObject()) {
> +        // On wayland use m_output to set action OSD position
> +        if (qGuiApp->platformName() == QLatin1String("wayland")) {

Correct grammar on push.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28916

To: bport, romangg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200417/319eee0b/attachment.html>


More information about the Plasma-devel mailing list