D28893: Detect Vivaldi based on binary name
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 16 22:25:30 BST 2020
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Vivaldi no longer includes its name in the User Agent, see [1].
Try detecting it based on binary name instead.
This could perhaps also be used to detect other chromium-based browsers such as Brave.
[1] https://www.google.de/search?q=vivaldi+user+agent+change
TEST PLAN
Should be good for 5.18 - coreaddons should have been an implicit dependency anyway?
- MPRIS identifies it as Vivaldi again.
- Its icon doesn't show up and I have no idea where the "vivadi" icon file it specifies in its desktop file is located
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D28893
AFFECTED FILES
CMakeLists.txt
host/CMakeLists.txt
host/settings.cpp
To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200416/7f40c660/attachment.html>
More information about the Plasma-devel
mailing list