D28832: Avoid creating subwindow on internal page widget

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWallet::openWallet takes a windowId as a parameter.
  
  QWidget->winId() is a dangerous call, it will create an underlying
  platform window when called. This happens even if we're not the toplevel
  widget. On X11 this passed winId must have always been broken, but not
  in a way that caused a problem.
  
  This leaves QtWayland in a very confused state with the side effect that
  all scrolling widgets become broken.
  
  BUG: 418755
  BUG: 420035

TEST PLAN
  Bisected drkonqi till we found the cause
  Verified fix by running crashtest (with some mods so I could report a bug)
  I can't confirm the winId is correct on X11, but the code looks safe

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28832

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200414/475bf935/attachment.html>