D28821: [Notifier] Port from KRun::runCommand

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 14 14:17:59 BST 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Use `ApplicationLauncherJob` for launching the main application and `CommandLauncherJob` for launching the updater.
  This also gives us a nice startup feedback for both cases now.
  The `KService::serviceByDesktopName` could in theory return `null` but imho that would be severely broken if we have the updater running but rest of Discover is absent.

TEST PLAN
  - "Show Discover" opens discover "recommendations"
  - "View updates" opens update view
  
  Both with a discover bouncy cursor

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28821

AFFECTED FILES
  notifier/CMakeLists.txt
  notifier/DiscoverNotifier.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200414/8a3830bb/attachment.html>


More information about the Plasma-devel mailing list