D28817: Fix KScreen output identifier position on wayland

[Roman Gilg]

romangg added a comment.


  Please explain your solution in the summary. I don't directly understand how this change fixes the bug. Thanks.

INLINE COMMENTS

> CMakeLists.txt:32
>      KF5::QuickAddons
> +    KF5::PlasmaQuick
>      KF5::Screen

lexicographic order

> output_identifier.cpp:69
>          if (config->supportedFeatures() & KScreen::Config::Feature::PerOutputScaling) {
> -            // no scale adjustment needed on Wayland
> -            logicalSize = deviceSize;
> +            // no scale adjustment needed on Wayland, we use logicalSize
> +            logicalSize = output->logicalSize().toSize();

When you're at it correct the grammar.

> output_identifier.h:24
>  
> -class QQuickView;
> +namespace PlasmaQuick {
> +    class Dialog;

style

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200414/559a08d5/attachment-0001.html>