D28744: Rewrite of the global shortcuts kcm

[Nicolas Fella]

nicolasfella added a comment.


  Cool stuff!

INLINE COMMENTS

> kcm_keys.cpp:110
> +{
> +    auto includedComponents = m_shortcutsModel->match(m_shortcutsModel->index(0, 0), ShortcutsModel::CheckedRole, true, -1);
> +    qCDebug(KCMKEYS) << "Exporting to " << url.toLocalFile();

const

> kcm_keys.cpp:159
> +            const KService::Ptr service = dialog->service();
> +            QString desktopFileName = service->entryPath().split('/').last();
> +            if (m_shortcutsModel->match(m_shortcutsModel->index(0, 0), ShortcutsModel::ComponentRole, desktopFileName).isEmpty()) {

const

> ShortcutActionDelegate.qml:27
> +
> +Loader{
> +    id: loader

space before {

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200413/136c7067/attachment-0001.html>