D28791: Manually merge stored and default settings

Fabian Vogt noreply at phabricator.kde.org
Mon Apr 13 13:54:40 BST 2020


fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Just have to make sure not to add anything to `DEFAULT_EXTENSION_SETTINGS.mpris.websiteSettings` now. Previously that would've been ignored.

INLINE COMMENTS

> utils.js:39
> +                    Object.keys(add).forEach((key) => {
> +                        if (!obj.hasOwnProperty(key)) {
> +                            obj[key] = add[key];

Why not if/else?

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28791

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200413/66f43472/attachment.html>


More information about the Plasma-devel mailing list