D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

Nicolas Fella noreply at phabricator.kde.org
Sun Apr 12 15:27:08 BST 2020


nicolasfella added inline comments.

INLINE COMMENTS

> config.cpp:99
> +{
> +    bool ret = true;
> +    for (KScreen::OutputPtr &output : m_data->outputs()) {

That sounds like a job for std::all_of

> config.h:50
>      void setDeviceOrientation(QOrientationReading::Orientation orientation);
> +    bool getAutoRotate();
>      void setAutoRotate(bool value);

const

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28773

To: z3ntu, #plasma, bshah
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200412/b0be65c0/attachment.html>


More information about the Plasma-devel mailing list