D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Piotr Dabrowski]

pdabrowski added a comment.


  Maybe I should explain my motives and probably that would let us (including me) understand the goal better.
  
  I use Night Color only occasionally and I want to turn it on *manually*.
  And I like my tray clean.
  So I only need this icon when I have it manually engaged (i.e. un-inhibited).
  
  But I perfectly understand the need for Timed modes, which are a great feature.
  So they should provide a good user experience as well.
  
  **CURRENT STATE:**
  
  Currently there is no Manual mode available. You can select "Always on" in configuration, which will engage it every time you log in. This is not good.
  
  And also the "[ ] Activate Night Color" checkbox together with the possibility to inhibit the feature is confusing.
  There seem to be two separate ways of controlling this feature.
  
  F8230238: night-color-0.png <https://phabricator.kde.org/F8230238>
  
  **PROPOSAL:**
  
  Maybe we could go with something like this:
  
  - Night Color system is always enabled (no "[ ] Activate Night Color" checkbox in the configuration)
  - by default set to Manual mode (see screenshot below)
  - Manual mode has a configuration option for setting the state at logon: "[ ] Active at logon" (unchecked by default)
  - the only way to disable the entire feature is what currently is named inhibition , which should be renamed to Disable
  
  F8230240: night-color-2.png <https://phabricator.kde.org/F8230240>
  
  Also we could also polish the naming... current wording used all over this feature are very confusing:
  
  - "activate" in the configuration
  - "active", "inhibited", "not running", "disabled" in the tooltip
  - "On" and "Off" in the toast OSD message
  
  My suggestion (consistent with the proposal above):
  
  - "active", "inactive" (used in tooltip) = Night Color in effect or not
  - "disabled" (used both in the tooltip and OSD) = what currently is named inhibition
  
  **CONCLUSION:**
  
  So with the Manual mode you have 2 states toggled from the tray icon: "disabled" or "active".
  And in Timed modes you can have it "disabled" from the tray icon or "inactive" (daytime) and "active" (at night) otherwise.
  
  **TRAY ICON:**
  
  As for the tray icon visibility (for the states above):
  
  - Manual mode: disabled=invisible, active=visible
  - Timed mode: disabled=invisible, inactive=invisible, active=visible
  
  And of course after setting the tray icon to "Always shown":
  
  - Manual mode: disabled=visible, active=visible
  - Timed mode: disabled=visible, inactive=visible, active=visible

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham, #vdg
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200410/39d7e2ef/attachment-0001.html>