D28705: Don't consider player gone when it only got temporarily added by us
Fabian Vogt
noreply at phabricator.kde.org
Fri Apr 10 11:23:13 BST 2020
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
In D28705#645038 <https://phabricator.kde.org/D28705#645038>, @broulik wrote:
> Yeah, wondering the same... maybe it didn't. Anyway this also fixes Spotify's previous/next buttons not working since when the player is gone we clear media session actions (not sure if that is someting we should do though)
Some logging reveals that with Vivaldi on Google translate there's a sequence of added, removed, added. After commenting out the `player.parentNode.removeChild(player);`, only an added event remains. So the removal triggers an add event?
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D28705
To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200410/a4de1882/attachment-0001.html>
More information about the Plasma-devel
mailing list