D28705: Don't consider player gone when it only got temporarily added by us

[Fabian Vogt]

fvogt added a comment.


  In D28705#644982 <https://phabricator.kde.org/D28705#644982>, @broulik wrote:
  
  > It worked on Chrome, and the properties can be accessed from the same context.
  >  It's just that the mutation.removedNodes loop above which is in content script cannot access those JS properties, so I had to change it, so it can.
  
  
  Before this patch it didn't attempt to read the property on Chrome either though, so I don't see how the `player.parentNode.removeChild(player);` didn't immediately result in the mutation observer to call `playerGone`.
  
  The change looks good, but I'm wondering how it ever worked previously...

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28705

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200409/9bd11f88/attachment.html>