D28705: Don't consider player gone when it only got temporarily added by us
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 9 17:17:42 BST 2020
broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
We temporarily add players created by JS to the DOM so we can access them from the content-script.
When the player is removed again - at least on Firefox - the MutationObserver notices that and we signal the player being gone.
This causes media controls for HTML5 Audio to be immediately rescinded when created but not played immediately.
TEST PLAN
Only Firefox seems to do this:
- Google Translate still works
- Can now properly control the voice samples on https://forvo.com/search/test/
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D28705
AFFECTED FILES
extension/content-script.js
To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200409/ae0c3ba5/attachment.html>
More information about the Plasma-devel
mailing list