D28692: Don't leak DrKonqi dialog / fix crash on wayland
David Edmundson
noreply at phabricator.kde.org
Wed Apr 8 23:26:26 BST 2020
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
When a QApplication is in it's destructor it calls window->destroy()
on all remaining QWindows. This deletes the platform window, whilst
keeping the real object alive. QtWayland doesn't like this.
Deleting the dialog fixes the issue. The deleteLater is fine because
QCoreApplication teardown is magic.
TEST PLAN
crashTest
REPOSITORY
R871 DrKonqi
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28692
AFFECTED FILES
src/main.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200408/ff0ff6b2/attachment.html>
More information about the Plasma-devel
mailing list