D28688: Document Kirigami::Icon

[Nicolas Fella]

nicolasfella added a comment.


  +1
  documentation improvements are always very welcome

INLINE COMMENTS

> icon.h:37
> +     * @include icon/FilesystemSource.qml
> +     * * The Internet:
> +     * @include icon/InternetSource.qml

Maybe instead of internet something like "a remote url" since it may be from the local network as well

> icon.h:69
> +    /**
> +     * The `implicitWidth` of this item, derived from the `source` image.
> +     */

Maybe mention that it's read-only. Do we have some standard way of doing that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28688

To: cblack, #kirigami
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200408/5734949b/attachment-0001.html>