D28666: Refactor for loops

Carson Black noreply at phabricator.kde.org
Wed Apr 8 14:48:24 BST 2020


cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Action.qml:156
> Why are you going through the prototype? Or is `children` not a "proper" Array?
> Also, can we use spread operator `...` here?
> And yes, please make those a bit more readable by using useful line breaks and using parentheses and braces.

It's a QML `list`, not an ECMAScript `Array`. Also, I don't see why you would need to use the spread operator here.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28666

To: cblack, #kirigami
Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200408/24728aaa/attachment.html>


More information about the Plasma-devel mailing list