D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM modulo some trivial code comment changes
  
  Probably a candidate for the stable branch.

INLINE COMMENTS

> kcm.cpp:268
> +            QString widgetStyle = cg.readEntry("widgetStyle", QString());
> +            // Some global theme refer to breeze's widgetStyle with a lower case b.
> +            if (widgetStyle == QStringLiteral("breeze")) {

s/theme/themes/

s/lower case/lowercase/

> kcm.cpp:422
> +    // Some global themes use styles that may not be installed.
> +    // Test if can apply style before updating the config.
> +    QScopedPointer<QStyle> newStyle(QStyleFactory::create(style));

s/if can apply style/if style can be installed/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28662

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200407/3d8f3e1e/attachment.html>