D28214: Add background portal

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> background.cpp:165
> +    qCDebug(XdgDesktopPortalKdeBackground) << "    enable: " << enable;
> +    qCDebug(XdgDesktopPortalKdeBackground) << "    commandline: " << commandline;
> +    qCDebug(XdgDesktopPortalKdeBackground) << "    flags: " << flags;

From the docs

  Commandline to use add when autostarting at login.
       If this is not specified, the Exec line from the
       desktop file will be used.

I can't see us doing that last part

> jgrulich wrote in background.cpp:194
> Doesn't need to? I think it just specifies that the desktop file should ignore the exec line and start it through DBus (assuming correct dbus service file is installed etc.). Or am I wrong?

> Doesn't need to? I think it just specifies that the desktop file should ignore the exec line and start it through DBus (assuming correct dbus service file is installed etc.). Or am I wrong?

You are right. We don't support it though.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28214

To: jgrulich, #plasma, davidedmundson, apol
Cc: bcooksley, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200407/79095782/attachment-0001.html>