D28616: Split KWin startup out of KSMServer

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Direction is beautiful, so much red!

INLINE COMMENTS

> logout.cpp:229
> +        auto saveSessionCall = m_kwinInterface->aboutToSaveSession(currentSession());
> +        saveSessionCall.waitForFinished(); // hehe
>      }

We do want a comment saying why we want to pause until kwin continues, and not going to deadlock.

I'm not sure "hehe" quite covers all of that.

> logout.cpp:248
>  {
> +    abort(); // FIXME IMPLEMENT NEW SAVING ALSO HERE!
>      if ( state != Idle )

well noticed :)

Blocking on that.

This is for when you use "manually saved session".

> server.h:214
>          Idle,
> -        LaunchingWM, Restoring,
> -        Shutdown, Checkpoint, Killing, KillingWM, WaitingForKNotify, // shutdown
> +        LaunchingWM /* FIXME rename this*/, Restoring,
> +        Shutdown, Checkpoint, Killing, KillingWMDONTUSETHIS, WaitingForKNotify, // shutdown

Can you not just kill them?
It's not public API

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28616

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200406/fd05e60c/attachment.html>