D28614: Add better player tab crash handling

Fabian Vogt noreply at phabricator.kde.org
Mon Apr 6 10:47:33 BST 2020


fvogt added a comment.


  In D28614#642630 <https://phabricator.kde.org/D28614#642630>, @broulik wrote:
  
  > > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again?
  >
  > I believe whenever a player starts playing again, it is propagated through MPRIS again. The `playerGone` handling is no different from the player being removed from DOM and being added back.
  
  
  Is there an "adding back" though? If I'm not completely wrong, for such a "ghost" tab, `currentPlayer()` would return `{}` and nothing happens anymore.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28614

To: broulik, #plasma, fvogt, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200406/3afb9012/attachment-0001.html>


More information about the Plasma-devel mailing list