D28544: RecentDocuments Runner: Cleanup and formatting

Méven Car noreply at phabricator.kde.org
Sat Apr 4 10:47:24 BST 2020


meven added a comment.


  Regarding the recentdocument krunner, I have a patch to make it rely on kactivity data : D26111 <https://phabricator.kde.org/D26111>. It has been waiting for review of a while.
  This patch will introduce a lot of conflict, but I am ok either way, if this one get merged first.
  
  Just a small nitpick on may part.

INLINE COMMENTS

> recentdocuments.cpp:107
>                  if (folderPath.startsWith(homePath)) {
> -                    folderPath.replace(0, homePath.length(), QStringLiteral("~"));
>                  }

You can replace with `KShell::tildeCollapse` for this if.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28544

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200404/98b267a9/attachment-0001.html>


More information about the Plasma-devel mailing list