D28154: Add users KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> UserDetailsPage.qml:101
> +                    layer.enabled: user.faceValid
> +                    layer.effect: OpacityMask {
> +                        maskSource: Rectangle {

Nice! How about an outline around the circle like we do in Kickoff?

> main.qml:66
> +                    layer.enabled: true
> +                    layer.effect: OpacityMask {
> +                        maskSource: Rectangle {

ditto

> ngraham wrote in main.qml:88
> Systemsettings' default window width is like five pixels too narrow to make both the users list and the details view appear by default. Can to make one or both a tiny bit smaller or otherwise fix it so that both are visible by default when you open the KCM in System Settings with its default window size?

Not actually fixed. Just open System Settings with its default window size and navigate to the new KCM and you'll see what I'm talking about.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200403/d374d5ae/attachment.html>