D28544: RecentDocuments Runner: Cleanup and formatting

[Alexander Lohnau]

alex created this revision.
alex added reviewers: davidedmundson, ngraham, broulik, meven, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  - Instead of early returning in the match method if the list of recent documents is empty the matching is suspended.
  - The imports have been cleaned up, redundant Q_UNUSED macros have been removed and the formatting has been changed.
  - Instead of getting the action using the id, all the actions are returned (in this case just the one that is set in the constructor).
  - The unnecessary comparison of the action has been removed and the replace method call uses a more performant overload.

TEST PLAN
  Should compile and show the recent documents.
  To test the suspendMatching: Clear the ~/.local/share/RecentDocuments folder, restart krunner.
  There should be no results. Then open a file in dolphin and the file shows up as a query result in krunner.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  recentdocuments_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28544

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp
  runners/recentdocuments/recentdocuments.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200403/7736482f/attachment-0001.html>