D28473: BookmarksRunner: Early return and formatting

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> firefox.cpp:198
> -            if (profilePath.isEmpty()) {
> -                //qDebug() << "No default firefox profile found";
> -                return;

Can you leave this in, and even promote it to an active qWarning* - if we have a db and profiles file, but can't determine the default profile, something is definitely wrong.

- better would be a qCWarning, but we have no categories here yet -> TODO

> firefox.cpp:214
>      } else {
> -        //qDebug() << "SQLITE driver isn't available";
>      }

This can IMHO also be promoted to an active warning.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28473

To: alex, bruns, broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200401/668da0d9/attachment.html>