D28383: Add PageRouter component

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> mart wrote in pagerouter.h:84
> how many routes an app would normally be going to have?
> 
> this seems really a thing for QQmlListProperty (which then each route must become a qobject tough)
> so routes: [
> Route {
> 
>   name: "home"
>   component: homeComponent
>   cache: true
>   initialProperties: {"name": "value,...}
> 
> },
> Route {}
> ]
> 
> which kindof becomes similar to pagepoolaction (which i still think they can be merged)

This is exactly what I was thinking. And if you mark it as default property you wouldn't even need to do the "routes: []" awkwardness.

> mart wrote in pagerouter.h:308
> quite ugly name..
> maybe isRouteActive

If you have routes as objects you could have an "active" property on the route, removing the need for this invokable.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28383

To: cblack, #kirigami, mart, davidedmundson
Cc: ahiemstra, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200401/d01bcb97/attachment.html>