D24251: [applets/kickoff] Somewhat fix the ConfigButtons component sizing
David Edmundson
noreply at phabricator.kde.org
Thu Sep 26 21:12:58 BST 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
ConfigButtons previously rendered one of the child item, the top title,
above itself. This means the layout containing it had to do bodgy layout
fixes to compensate above and take negative margins off the bottom.
Code still isn't great, but that one issue is resolved.
TEST PLAN
Added a red rectangle with anchors.fill: configButton
That rectangle is now sane
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24251
AFFECTED FILES
applets/kickoff/package/contents/ui/ConfigButtons.qml
applets/kickoff/package/contents/ui/ConfigGeneral.qml
To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190926/6d9bdc8f/attachment.html>
More information about the Plasma-devel
mailing list