D24147: fix compatibility with Qt5.11

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Sep 23 13:39:06 BST 2019


broulik added inline comments.

INLINE COMMENTS

> ActionToolBar.qml:173
>                  icon.name: "overflow-menu"
> -                children: Array.prototype.map.call(root.actions, i => i).concat(Array.prototype.map.call(hiddenActions, i => i))
> +                children: Array.prototype.map.call(root.actions, i = i).concat(Array.prototype.map.call(hiddenActions, i = i))
>              }

I don't think you can replace arrow functions by a simple assignment. Isn't this just a hack to turn that list into an `Array`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24147

To: mgallien, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190923/56e85b77/attachment-0001.html>


More information about the Plasma-devel mailing list