D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> appearancegtk2.cpp:96
> +
>      if (gtkrc.open(QIODevice::ReadOnly | QIODevice::Text)) {
>          QString fileContents{gtkrc.readAll()};

I think file creation could be simplified. Just replace WriteOnly flag with ReadWrite here. This would mean, that file will be created automatically if it doesn't exist. If you think intention to open file also for write is unclear, write a comment alongside.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D24087

To: heikobecker, gikari, #plasma, apol, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190919/0b6bfeab/attachment.html>