D24070: Don't use toolTipMainText to show info, rather use the second line

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> batterymonitor.qml:70
> +            if (remainingTime > 0) {
> +                return i18n("%1 Remaining", KCoreAddons.Format.formatDuration(remainingTime, KCoreAddons.FormatTypes.HideSeconds))
> +            }

un-capitalize the R

> batterymonitor.qml:70
> +            if (remainingTime > 0) {
> +                return i18n("%1 Remaining", KCoreAddons.Format.formatDuration(remainingTime, KCoreAddons.FormatTypes.HideSeconds))
> +            }

Un-capitalize the R

> batterymonitor.qml:89
>              if (state === "Charging") {
> -                return i18n("%1% Charging", percent)
> +                return i18n("%1% Battery charge level", percent)
>              } else if (state === "NoCharge") {

Un-capitalize the B

> batterymonitor.qml:93
>              } else {
> -                return i18n("%1% Plugged in", percent)
> +                return i18n("%1% Battery charge level", percent)
>              }

Un-capitalize the B

> batterymonitor.qml:96
>          } else {
> -            if (remainingTime > 0) {
> -                return i18nc("%1 is remaining time, %2 is percentage", "%1 Remaining (%2%)",
> -                             KCoreAddons.Format.formatDuration(remainingTime, KCoreAddons.FormatTypes.HideSeconds),
> -                             pmSource.data["Battery"]["Percent"])
> -            } else {
> -                return i18n("%1% Battery Remaining", pmSource.data["Battery"]["Percent"]);
> -            }
> +            return i18n("%1% Battery charge level", pmSource.data.Battery.Percent)
>          }

Un-capitalize the B

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190919/8a41c798/attachment-0001.html>