D23798: Polish Displays KCM UI

[Roman Gilg]

romangg added a comment.


  Reducing the screen area height makes it difficult to place outputs on top of each other. Making it a bit smaller is fine (and improving the logic of how much this it in comparison to overall kcm size) but I think this is too much. Alternatively the size of the outputs could be reduced.

INLINE COMMENTS

> GB_2 wrote in OutputPanel.qml:33
> `element.count > 1`

`element` or `model` is not the whole model but only the current element of the model displayed by the view delegate. So it's a single element of the model without a count.

What you need is to take the count on the overall model. As the OutputPanel is part of Panel you can use for example here `panelView.count`. This way an additional getter is not required. Also you could use `OutputModel::rowCount` as in: `kcm.outputModel.rowCount()` (it is already Q_INVOKABLE, see docs <https://doc.qt.io/qt-5/qabstractitemmodel.html#rowCount>).

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/2e110e04/attachment-0001.html>