D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

Nathaniel Graham noreply at phabricator.kde.org
Mon Sep 16 19:01:24 BST 2019


ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, Pinned Icons-Only Task Manager launchers are capable of showing progress
  information even when they're not running, because the app didn't unset the progress
  information before quitting, or crashed in the middle of an operation. But the concept
  of an in-progress operation for an app that isn't running doesn't make logical sense.
  
  This patch fixes that UI issue by only allowing pinned IOTM apps to show progress
  information while they're actually running.
  
  BUG: 409687
  FIXED-IN: 5.17.0

TEST PLAN
  Pinned Elisa app no longer shows progress information on its icon after quitting while
  playing a song
  
  Pinned Discover app no longer shows progress information on its icon after crashing in 
  the middle of an update
  
  IOTM apps still shows progress information while running
  
  No change for regular Task Manager

REPOSITORY
  R119 Plasma Desktop

BRANCH
  dont-show-progress-indicator-for-non-running-apps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24001

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/c6c1dae3/attachment.html>


More information about the Plasma-devel mailing list