D23984: [System Settings] redesign intro page

Nathaniel Graham noreply at phabricator.kde.org
Mon Sep 16 18:32:10 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> introPage.qml:85
>          }
> -        width: Math.round(parent.width * 0.8)
> +        width: parent.width * 0.8
> +

Why change this? Rounding generally fixes the problem of blurriness with fractional scaling due to non-integer pixels.

> introPage.qml:88
>          Kirigami.Heading {
> +            id: frequentlyUsed
>              Layout.alignment: Qt.AlignHCenter

No need to add an id since nothing references it

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23984

To: tienisto, #vdg, GB_2, ngraham
Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/84876903/attachment.html>


More information about the Plasma-devel mailing list