D23983: [Notifications] Create KFilePlacesModel when needed
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Sep 16 08:40:04 BST 2019
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
A job instance is created as soon as the job starts but it might not be shown to the user right away or at all.
`JobPrivate::prettyDestUrl()` already creates the `KFilePlacesModel` if needed, no need to do it in the constructor.
TEST PLAN
- Started a file copy, got the `KFilePlacesModel` created only after 500ms when the copy dialog showed up
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D23983
AFFECTED FILES
libnotificationmanager/job_p.cpp
To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/d2c79a0a/attachment.html>
More information about the Plasma-devel
mailing list