D23980: [Folder View] Don't explicitly initialize fontMetrics

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `qApp->fontMetrics()` calls `desktop()` which creates a `QDesktopWidget` and might do so on a non-main thread in case of threaded rendering.
  
  BUG: 411953
  FIXED-IN: 5.12.10

TEST PLAN
  - Verified that the default-initialized `opt.fontMetrics` matches the `qApp->fontMetrics()`
  
  - Rubber band still looks normal

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23980

AFFECTED FILES
  containments/desktop/plugins/folder/rubberband.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190916/6c5d9402/attachment.html>