D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

Nathaniel Graham noreply at phabricator.kde.org
Sun Sep 15 21:32:00 BST 2019


ngraham added a comment.


  In D23868#532046 <https://phabricator.kde.org/D23868#532046>, @guoyunhe wrote:
  
  > In D23868#532016 <https://phabricator.kde.org/D23868#532016>, @ngraham wrote:
  >
  > > Maybe in the interests of #consistency <https://phabricator.kde.org/tag/consistency/>, let's make the filter feature look the same way that it does in the Colors KCM: F7357040: Screenshot_20190915_131425.png <https://phabricator.kde.org/F7357040>
  >
  >
  > There is a major difference: the color filter is a combobox but the font filter is a menu with checkbox and child menu. I cannot change it to a combobox but can swap the order and try to add borders.
  
  
  Radio buttons, not checkboxes. Which means the entries are all mutually exclusive, which means it could actually be a combobox, but for the fact that some of its items have sub-menus.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23868

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190915/71dd71f3/attachment.html>


More information about the Plasma-devel mailing list