D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Awesome, so close! We're just at little nitpick territory now.

INLINE COMMENTS

> IconGridDelegate.qml:69
>  
> -    PlasmaComponents.Label {
> +    QQC2.Label {
>          font.pointSize: iconSize > 96 ? theme.defaultFont.pointSize : theme.smallestFont.pointSize

There's a lot of commented code in here that could also be cleaned up

> Preview.qml:254
> +                QQC2.MenuItem {
> +                    text: i18n("Screenshot with Active Colorscheme")
> +                    onTriggered: {

Colorscheme -> Color Scheme

> SvgGrid.qml:92
>              opacity: iconGrid.currentIndex == index ? 1.0 : 0.7
>              anchors {
>                  left: parent.left

Could also get rid of the commented code in here

> Tools.qml:111
> +        QQC2.ComboBox {
> +            model: ["System Colorscheme", "Breeze (Normal)", "Breeze Dark"]
> +            delegate: QQC2.ItemDelegate {

System Colorscheme -> System Color Scheme

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190914/fb7f8488/attachment.html>