D23845: Add a mode to center actions and omit the title when using a ToolBar style

[Marco Martin]

mart added a comment.


  Like the concept, API may need a bit of improvement

INLINE COMMENTS

> PageRow.qml:146
>       * * showNavigationButtons: OR flags combination of ApplicationHeaderStyle.ShowBackButton and ApplicationHeaderStyle.ShowForwardButton
> +     * * toolbarButtonsCenteredWithNoTitle: When using the ToolBar style, center the actions and don't show a title
>       * * minimumHeight: (int) minimum height of the header, which will be resized when scrolling, only in Mobile mode (default: preferredHeight, sliding but no scaling)

This name for property is a bit... Meh
I would export a qt.alignment property *and* the icon position enum

> ToolBarPageHeader.qml:72
>              verticalCenter: parent.verticalCenter
> -            right: ctxActionsButton.visible ? ctxActionsButton.left : parent.right
>          }

Perhaps a state machine with AnchorChange may make it a bit better and reliable

REPOSITORY
  R169 Kirigami

BRANCH
  optional-centered-actions-with-no-title (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23845

To: ngraham, #kirigami, #vdg, mart, ndavis
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190911/e3b299e6/attachment.html>