D23798: Polish Displays KCM UI
Björn Feber
noreply at phabricator.kde.org
Tue Sep 10 14:55:07 BST 2019
GB_2 added inline comments.
INLINE COMMENTS
> OutputPanel.qml:33
> + text: i18n("Settings for %1", element.display)
> + visible: kcm.numberOfOutputs > 1
> + }
`element.count > 1`
> OutputPanel.qml:42
> onClicked: element.enabled = checked
> + visible: kcm.numberOfOutputs > 1
> }
`element.count > 1`
> OutputPanel.qml:49
> onClicked: element.primary = checked
> - visible: kcm.primaryOutputSupported
> + visible: kcm.primaryOutputSupported && kcm.numberOfOutputs > 1
> }
`element.count > 1`
> GB_2 wrote in main.qml:123
> You don't need any of that. Just do `kcm.outputModel.count > 1`. BTW, I'd also use a different minimum height if this component is hidden.
Or even better: `outputs.count > 1`
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D23798
To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190910/78af1942/attachment-0001.html>
More information about the Plasma-devel
mailing list