D12827: Added process details in the process list context menu

[Méven Car]

meven added a comment.


  In D12827#527480 <https://phabricator.kde.org/D12827#527480>, @chrisx wrote:
  
  > Patch updated. Any suggestions?
  
  
  You have a few code indentation issues, that you can take care of.
  https://phabricator.kde.org/D12827#inline-130952
  
  And I think you should rename `DetailsDlg` to `DetailsDialog`, we prefer to avoid abbreviations in classes names as a convention.
  
  Also the patch does not apply on master but I guess it depends on D23287 <https://phabricator.kde.org/D23287> which also needs to be rebased on master...

REVISION DETAIL
  https://phabricator.kde.org/D12827

To: chrisx, broulik, davidedmundson, mart
Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190909/8cbbeba1/attachment.html>