D23808: Don't create() windows that aren't native, upon receiving a palette change event.

David Faure noreply at phabricator.kde.org
Mon Sep 9 21:47:20 BST 2019


dfaure created this revision.
dfaure added reviewers: carewolf, davidedmundson, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  run kmail or falkon, then run kcmshell5 fonts, change font size
  
  ASSERT: "!d->offscreenWindow->handle()" in file /d/qt/5/kde/qtdeclarative/src/quickwidgets/qquickwidget.cpp, line 1014
  
  Apparently that QQuickWindow should not be create()d so calling winId()
  unconditionally here is a bad idea, skip non-native windows.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23808

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: dfaure, carewolf, davidedmundson, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190909/a276890c/attachment.html>


More information about the Plasma-devel mailing list