D23803: [Folder View] Add subtle shadows to icons

Nathaniel Graham noreply at phabricator.kde.org
Mon Sep 9 17:52:02 BST 2019


ngraham created this revision.
ngraham added reviewers: hein, Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Folder View items currently have shadows behind their labels, but not their icons.
  
  This patch adds a very subtle shadow for the icons as well, which improves contrast
  for some backgrounds and just looks classy IMO. :)
  
  FEATURE: 411607
  FIXED-IN: 5.17.0

TEST PLAN
  Before: F7334103: Before.png <https://phabricator.kde.org/F7334103>
  After: F7334104: After.png <https://phabricator.kde.org/F7334104>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-subtle-icon-shadow-to-folderview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23803

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderItemDelegate.qml

To: ngraham, hein, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190909/c8920d23/attachment.html>


More information about the Plasma-devel mailing list