D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

Kishore Gopalakrishnan noreply at phabricator.kde.org
Sun Sep 8 11:48:53 BST 2019


kishoreg added a comment.


  The problem is that the original patch was changing the maximum range of the sliders for application streams and microphones as well. This seemed a bit counter-intuitive, as for example capping the volumes of both the speaker and the music player at 15% would lead to an 'effective volume' of 2.25%. There was also the issue that the slider maximum ranges for applications displayed this weird behaviour of having the reduced range applied only after the user interacted with them. In addition, the behaviour was inconsistent with the behaviour when the maximum volume is >100% (it doesn't automatically apply 'raise maximum volume' to application streams, for instance). After applying this patch, the limit only applies to the hardware volume keys and scrolling on the applet, which is also consistent with the behaviour when the limit is set to >100%.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23768

To: kishoreg, ngraham, romangg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190908/af0a57cd/attachment.html>


More information about the Plasma-devel mailing list