D23784: Remove custom content item from ActionMenu separator

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that, LGTM +1

INLINE COMMENTS

> ActionsMenu.qml:32
>      property Component itemDelegate: Component {ActionMenuItem {}}
> -    property Component separatorDelegate: Component {
> -        Controls.MenuSeparator {
> -            contentItem: Rectangle {
> -                implicitHeight: Math.floor(Kirigami.Units.devicePixelRatio)
> -                color: Qt.tint(Kirigami.Theme.textColor, Qt.rgba(Kirigami.Theme.backgroundColor.r, Kirigami.Theme.backgroundColor.g, Kirigami.Theme.backgroundColor.b, 0.7))
> -            }
> -        }
> -    }
> +    property Component separatorDelegate: Component { Controls.MenuSeparator { } }
>      property QtObject parentAction

I don't think the Component {} wrapping is necessary.

REPOSITORY
  R169 Kirigami

BRANCH
  menu_separator

REVISION DETAIL
  https://phabricator.kde.org/D23784

To: ahiemstra, #kirigami, mart, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190908/60d53929/attachment.html>