D23783: [kcm] Fix i18n output file name and split texts

Pino Toscano noreply at phabricator.kde.org
Sun Sep 8 09:47:55 BST 2019


pino added a comment.


  In D23783#527575 <https://phabricator.kde.org/D23783#527575>, @romangg wrote:
  
  > In D23783#527562 <https://phabricator.kde.org/D23783#527562>, @pino wrote:
  >
  > > Please do not split the messages just for sake of column width.
  >
  >
  > If there is a better solution than splitting text with a `+` while still respecting the line chars limit I will upload a new patch.
  
  
  Even reading the other RR, I still do not understand how this 100 chars limit is so important, even to make i18n worse.
  
  >> What about just removing the `+` to concatenate the strings, and just use normal continuation, i.e.:
  >> 
  >>   text: i18n("Are you sure you want to disable all outputs? "
  >>              "This might render the device unusable.")
  > 
  > This sadly didn't work. The KCM just doesn't start then with an error message. Does the macro need to be improved to support this?
  
  Which macro?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23783

To: romangg, #plasma, victorr, yurchor
Cc: pino, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190908/db5d7ea3/attachment-0001.html>


More information about the Plasma-devel mailing list