D23773: Observe title tag only if there actually is a player
Fabian Vogt
noreply at phabricator.kde.org
Sat Sep 7 14:44:59 BST 2019
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in content-script.js:333
> An empty title is kinda pointless anyway, so this is on purpose
It would still send an empty title on initialization or changes after the first change though. So if that's the purpose of the empty string assignment, it should be done differently.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23773
To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190907/035de1ca/attachment.html>
More information about the Plasma-devel
mailing list