D23773: Observe title tag only if there actually is a player

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in content-script.js:333
> This is to store the name and only send a change when it is different from last time I sent it. `document.title` will be the same as `titleTag.innerText` rendering this check moot

No, it won't be. Currently it won't send a notification if the title changes to an empty string as `document.title` was sent initially (line 319)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23773

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190907/fd8dcc6a/attachment-0001.html>