D23712: [Cuttlefish] Overhaul program, use Kirigami

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  There are some inline comments that aren't done yet. Also, the slider's text label still says 81 and 162 instead of 64 and 128 for the last two slider values.

INLINE COMMENTS

> Tools.qml:102
> +        color: Kirigami.Theme.textColor
> +        height: 1
> +        anchors {

Is any of this custom styling actually necessary given `Kirigami.Separator`'s default appearance?

> ngraham wrote in Tools.qml:30
> The fake toolbar created here feels too short. I would make it taller by a few pixels so there's more room above and below the controls.

Now it's a bit too tall, and the margins above and below the search field still don't match the left margins: F7320966: Screenshot_20190905_071959.png <https://phabricator.kde.org/F7320966>

> ngraham wrote in Tools.qml:42
> Don't need to override the default placeholder text when using `Kirigami.SearchField`

Not done yet.

> ngraham wrote in cuttlefish.qml:24
> ditto

Not done

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D23712

To: cblack, #vdg, ngraham
Cc: ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190905/64cf7cdf/attachment.html>